Firestore: pin googletest to a commit that supports c++14 in cmake builds #14474
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Before this PR, Firestore's cmake build always built against the
mainbranch of https://github.com/google/googletest:firebase-ios-sdk/cmake/external/googletest.cmake
Line 23 in bbd9fb3
This worked fine, until googletest dropped c++14 support on Feb 10, 2025 in commit google/googletest@c00fd25. Since firebase-ios-sdk requires c++14 support, this caused all sorts of build errors (see examples below). The fix in this PR is to pin googletest at the last commit that supported c++14.
and
#no-changelog