Skip to content

[VertexAI] Add support for token-based usage metrics #14406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 11, 2025
Merged

[VertexAI] Add support for token-based usage metrics #14406

merged 14 commits into from
Feb 11, 2025

Conversation

@rlazo
Copy link
Contributor

@rlazo rlazo commented Jan 31, 2025

Token measurement is broken down by modaliy, with separate counters for image, audio, etc.
rlazo added 2 commits January 30, 2025 14:31
@rlazo
[VertexAI] Add support for token-based usage metrics
a020a42 
Token measurement is broken down by modaliy, with separate counters for image, audio, etc.
@rlazo
Update comments in Modality
b685105
@rlazo rlazo requested a review from andrewheard January 31, 2025 00:01
@rlazo
Copy link
Contributor Author

rlazo commented Feb 8, 2025

friendly ping
@rlazo rlazo enabled auto-merge (squash) February 8, 2025 04:17
@rlazo rlazo requested a review from paulb777 February 11, 2025 15:25
andrewheard
andrewheard reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple minor test nits.

Note: I'm going to add integration tests in a separate PR.
@rlazo rlazo requested a review from andrewheard February 11, 2025 20:39
@rlazo
Copy link
Contributor Author

rlazo commented Feb 11, 2025

Comments addressed. Also, added change to make fields non-nullable

cc @andrewheard
andrewheard
andrewheard approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI.
@rlazo rlazo merged commit 44fe5d0 into main Feb 11, 2025
30 of 38 checks passed
@rlazo rlazo deleted the rl.token.count.breakdown branch February 11, 2025 20:41
@andrewheard andrewheard mentioned this pull request Feb 11, 2025
Merged
@github-actions github-actions bot mentioned this pull request Feb 26, 2025
Merged
@firebase firebase locked and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firebaseai

4 participants

@rlazo @paulb777 @andrewheard @google-oss-bot