Skip to content

[Auth] Make two string properties atomic #14308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

[Auth] Make two string properties atomic #14308

merged 1 commit into from
Jan 7, 2025

Conversation

@ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jan 6, 2025 •
edited by paulb777
Loading

Possible fix for #14196 until the SDK is fully synchronized with structured concurrency.
@google-oss-bot
Copy link

google-oss-bot commented Jan 6, 2025

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@ncooke3 ncooke3 requested a review from morganchen12 January 7, 2025 15:17
@ncooke3 ncooke3 marked this pull request as ready for review January 7, 2025 15:58
@ncooke3 ncooke3 merged commit e5a7384 into main Jan 7, 2025
55 checks passed
@ncooke3 ncooke3 deleted the nc/14196 branch January 7, 2025 17:55
@paulb777
Copy link
Member

paulb777 commented Jan 7, 2025

@ncooke3 Should we add a changelog that notes fixing #14196?
@ncooke3
Copy link
Member Author

ncooke3 commented Jan 7, 2025

@ncooke3 Should we add a changelog that notes fixing #14196?

Yes, will roll it into the 11.7 changelog PR.
@ncooke3 ncooke3 linked an issue Jan 7, 2025 that may be closed by this pull request
[Crash] Auth.possiblyPostAuthStateChangeNotification() over released #14196
Closed
@github-actions github-actions bot mentioned this pull request Jan 14, 2025
Merged
@firebase firebase locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: auth

4 participants

@ncooke3 @google-oss-bot @paulb777 @morganchen12