Skip to content

Remove dead code from FirebaseRemoteConfig #14153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 21, 2024
Merged

Remove dead code from FirebaseRemoteConfig #14153

merged 3 commits into from
Nov 21, 2024

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Nov 20, 2024

Internal Metatdata does not get used from any public APIs
@google-oss-bot
Copy link

google-oss-bot commented Nov 20, 2024

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777 paulb777 requested a review from karenyz November 20, 2024 21:26
karenyz
karenyz reviewed Nov 21, 2024
View reviewed changes
karenyz
karenyz approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@karenyz karenyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
@paulb777 paulb777 merged commit 7cfb06f into main Nov 21, 2024
47 checks passed
@paulb777 paulb777 deleted the pb-rc-deadcode branch November 21, 2024 03:54
@paulb777 paulb777 mentioned this pull request Nov 21, 2024
Merged
@github-actions github-actions bot mentioned this pull request Dec 4, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: remoteconfig

3 participants

@paulb777 @google-oss-bot @karenyz