[Auth] Synchronize static method of AuthDefaultUIDelegate on main actor #14112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
paulb777 approved these changes Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Method's Implementation uses a lot of main actor isolated APIs, so I think it makes sense to isolate the entire method on the main actor.
The caller of this API is in a DispatchQueue.main.async {} which is isolated on the main actor so no call sites need to change.
Other no-op changes were to make the class final and switch the method from a class method to a static method.
#no-changelog