Fix a crash that happens when the application changes states. #14102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…re registering for notifications. Fix #13174.
themiswang approved these changes Nov 12, 2024
paulb777 reviewed Nov 13, 2024
Member
paulb777 left a comment
paulb777 left a comment There was a problem hiding this comment.
The unit test failures look related. Please fix
Contributor Author
Fixed all the tests to move ahead. Planning to submit this tomorrow unless there are any comments/blockers. |
paulb777 approved these changes Nov 14, 2024
ncooke3 reviewed Nov 14, 2024
ncooke3 approved these changes Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix a crash that happens when the application changes states and we are registering for notifications.
Fix #13174.