Skip to content

When token fetch fails, return the failure reason to the client. #14014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2024
Merged

When token fetch fails, return the failure reason to the client. #14014

merged 3 commits into from
Nov 5, 2024

Conversation

@leojaygoogle
Copy link
Contributor

@leojaygoogle leojaygoogle commented Nov 2, 2024 •
edited
Loading

Currently, when token fetch fails, a generic and misleading message like this is shown:

Invalid fetch response, expected 'token' or 'Error' key

After this PR, the actual failure reason returned from the server will be logged and returned to the client.

This is expected to fix issue #13997.

#no-changelog
@leojaygoogle
When token fetch fails, return the failure reason to the client.
62ff252 
Currently, when token fetch fails, a generic and misleading message like this is shown: > Invalid fetch response, expected 'token' or 'Error' key After this PR, the actual failure reason returned from the server will be logged and returned to the client.
@google-oss-bot
Copy link

google-oss-bot commented Nov 2, 2024

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@leojaygoogle leojaygoogle marked this pull request as ready for review November 2, 2024 02:56
@ncooke3 ncooke3 linked an issue Nov 2, 2024 that may be closed by this pull request
Failure to fetch token fails to report server error #13997
Closed
ncooke3
ncooke3 approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Please add a changelog entry that references the GH issue.
@leojaygoogle
Copy link
Contributor Author

leojaygoogle commented Nov 5, 2024

Done.
@leojaygoogle leojaygoogle merged commit 91cb594 into main Nov 5, 2024
23 checks passed
@leojaygoogle leojaygoogle deleted the TOO_MANY_REGISTRATIONS branch November 5, 2024 08:12
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: messaging

3 participants

@leojaygoogle @google-oss-bot @ncooke3