- Notifications
You must be signed in to change notification settings - Fork 1.7k
Add custom signals support in Remote Config. #13976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
Apple API Diff ReportCommit: 005e4b8 FirebaseRemoteConfigClassesFIRRemoteConfig[ADDED] -setCustomSignals:withCompletion:Objective-C: + - ( void ) setCustomSignals :( nonnull NSDictionary < NSString * , NSObject *> * ) customSignals withCompletion :( void ( ^ _Nullable )( NSError * _Nullable error )) completionHandler NS_REFINED_FOR_SWIFT ;Constants[ADDED] FIRRemoteConfigCustomSignalsErrorDomain[ADDED] FIRRemoteConfigCustomSignalsErrorDomainSwift: + let RemoteConfigCustomSignalsErrorDomain : String Objective-C: + extern NS_SWIFT_NAME ( RemoteConfigCustomSignalsErrorDomain ) NSString * const FIRRemoteConfigCustomSignalsErrorDomainEnumerations[ADDED] FIRRemoteConfigCustomSignalsError[ADDED] FIRRemoteConfigCustomSignalsErrorSwift: + typealias RemoteConfigCustomSignalsError . Code . _ErrorType = RemoteConfigCustomSignalsError + case unknown = 8101 + case invalidValueType = 8102 + case limitExceeded = 8103 Objective-C: + enum FIRRemoteConfigCustomSignalsError : NSInteger {} + FIRRemoteConfigCustomSignalsErrorUnknown = 8101 + FIRRemoteConfigCustomSignalsErrorInvalidValueType = 8102 + FIRRemoteConfigCustomSignalsErrorLimitExceeded = 8103 |
themiswang reviewed Oct 29, 2024
themiswang reviewed Oct 29, 2024
themiswang reviewed Oct 29, 2024
themiswang reviewed Oct 29, 2024
karenyz reviewed Oct 30, 2024
karenyz reviewed Nov 8, 2024
ncooke3 reviewed Dec 9, 2024
paulb777 reviewed Dec 9, 2024
ncooke3 approved these changes Dec 9, 2024
paulb777 approved these changes Dec 9, 2024
Member
paulb777 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tusharkhandelwal8 Thanks for working through all the feedback. LGTM!
ncooke3 reviewed Dec 13, 2024
ncooke3 approved these changes Dec 19, 2024
Member
ncooke3 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
feat(rc): Add method to set custom signals for Remote Config Custom targeting