Skip to content

Keep FirebaseCore, FirebaseCoreExtension and FirebaseCoreInternal pod versions aligned to latest #13953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2024
Merged

Keep FirebaseCore, FirebaseCoreExtension and FirebaseCoreInternal pod versions aligned to latest #13953

merged 2 commits into from
Oct 23, 2024

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Oct 22, 2024

Prevent future breakages like #13942

There is no real value in letting these versions diverge and this better matches SPM
@google-oss-bot
Copy link

google-oss-bot commented Oct 22, 2024

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777
Copy link
Member Author

paulb777 commented Oct 22, 2024

CI failures look to be related to SpecStaging revert for 11.4.x testing
@ncooke3 ncooke3 mentioned this pull request Oct 22, 2024
Merged
@paulb777 paulb777 requested a review from ncooke3 October 23, 2024 15:11
@ncooke3
Copy link
Member

ncooke3 commented Oct 23, 2024

I think we should also change FirebaseCoreExtension.podspec to have a strict dependency on FirebaseCore as well:

firebase-ios-sdk/FirebaseCoreExtension.podspec

Line 37 in a7e7eb1

s.dependency 'FirebaseCore', '~> 11.0'

Because like in the Flutter bug, FirebaseAuth v11.2's floating depending on FirebaseCoreExtension allowed it depend on a newer FirebaseCoreExtension. If FirebaseCoreExtension strictly depended on FirebaseCore, it would prevent this float when using pods from the Firebase.podspec. because the Firebase.podspec strictly depends on a FirebaseCore version. Flutter currently uses the Firebase pod: https://github.com/firebase/flutterfire/blob/b5511588fed0762c102cf1e0b96a3f2e365ae2dd/packages/firebase_auth/firebase_auth/ios/firebase_auth.podspec#L34-L35
@paulb777 paulb777 changed the title Keep FirebaseCore and FirebaseCoreInternal pod versions aligned Keep FirebaseCore, FirebaseCoreExtension and FirebaseCoreInternal pod versions aligned to latest Oct 23, 2024
@paulb777 paulb777 merged commit 36da449 into main Oct 23, 2024
392 of 400 checks passed
@paulb777 paulb777 deleted the pb-lockstep-coreinternal branch October 23, 2024 17:28
@ncooke3
Copy link
Member

ncooke3 commented Oct 23, 2024

Thanks! Will re-stage and re-tag.
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Merged
@firebase firebase locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: abtesting api: analytics api: appcheck api: appdistribution api: auth api: core api: crashlytics api: database api: dynamiclinks api: firebaseai api: firestore api: functions api: inappmessaging Firebase In App Messaging api: installations api: messaging api: performance api: remoteconfig api: storage release-tooling

3 participants

@paulb777 @google-oss-bot @ncooke3