[Auth] Address possible race condition #13772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
ncooke3 reviewed Oct 3, 2024
paulb777 force-pushed the pb-possible-race-fix branch from 4533c71 to 513c956 Compare Druzrka pushed a commit to Druzrka/firebase-ios-sdk that referenced this pull request Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR eliminates the possibility of multiple AuthBackendRPCImplementation instances other than in test code.
It's a possible fix for #13761
(Also eliminates an Objective-C unit test that was relying upon the broken old code to succeed on GHA.