[Auth] Convert LoginView to SwiftUI #13628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
peterfriese reviewed Oct 11, 2024
FirebaseAuth/Tests/SampleSwift/AuthenticationExample/CustomViews/LoginView.swift Outdated Show resolved Hide resolved
peterfriese reviewed Oct 11, 2024
FirebaseAuth/Tests/SampleSwift/AuthenticationExample/CustomViews/LoginView.swift Outdated Show resolved Hide resolved
peterfriese reviewed Oct 11, 2024
FirebaseAuth/Tests/SampleSwift/AuthenticationExample/CustomViews/LoginView.swift Outdated Show resolved Hide resolved
ncooke3 commented Oct 14, 2024
FirebaseAuth/Tests/SampleSwift/AuthenticationExample/CustomViews/LoginView.swift Show resolved Hide resolved
…s/LoginViewSwiftUI.swift
ncooke3 force-pushed the nc/swiftui-auth branch from da98405 to ee561f4 Compare ncooke3 commented Dec 12, 2024
FirebaseAuth/Tests/SampleSwift/AuthenticationExample/CustomViews/LoginView.swift Show resolved Hide resolved
paulb777 approved these changes Dec 13, 2024
Member Author
| Will address any further feedback in a following PR. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
New UI for email/password page:
#no-changelog