Skip to content

Testing composite index queries against production #11865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 63 commits into from
Oct 20, 2023
Merged

Testing composite index queries against production #11865

merged 63 commits into from
Oct 20, 2023

Conversation

@milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Sep 28, 2023 •
edited
Loading

#no-changelog
port from firebase/firebase-js-sdk#7632
@google-oss-bot
Copy link

google-oss-bot commented Sep 28, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.14% (579914e) to 88.09% (505ba78) by -0.05%.

    FilenameBase (579914e)Merge (505ba78)Diff
    exception.cc84.21%23.68%-60.53%
    leveldb_key.cc98.14%98.82%+0.69%
    leveldb_remote_document_cache.cc94.83%96.55%+1.72%
    ordered_code.cc93.90%94.39%+0.49%
    write_stream.cc94.37%91.55%-2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qMsWx3ifGI.html
@milaGGL milaGGL marked this pull request as ready for review September 29, 2023 13:44
@milaGGL milaGGL requested a review from ehsannas September 29, 2023 13:57
ehsannas
ehsannas reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good. Please add the extra few functions the same as the Web.
@milaGGL milaGGL assigned ehsannas and unassigned milaGGL Oct 18, 2023
@milaGGL milaGGL requested a review from ehsannas October 19, 2023 14:54
ehsannas
ehsannas approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@ehsannas ehsannas assigned milaGGL and unassigned ehsannas Oct 19, 2023
@milaGGL milaGGL merged commit 33cf815 into master Oct 20, 2023
@milaGGL milaGGL deleted the mila/composite-index-testing branch October 20, 2023 14:15
@firebase firebase locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore

6 participants

@milaGGL @google-oss-bot @paulb777 @andrewheard @ehsannas @ncooke3