Skip to content

Sync spec tests from web SDK to iOS SDK #10391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2022
Merged

Sync spec tests from web SDK to iOS SDK #10391

merged 1 commit into from
Oct 25, 2022

Conversation

@milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Oct 21, 2022 •
edited
Loading

instruction to syncing spec tests from web to android SDK: firebase-js-sdk/packages/firestore/test/unit/specs/README.md
@google-oss-bot
Copy link

google-oss-bot commented Oct 22, 2022

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.23% (646e6a9) to 88.20% (99a876c) by -0.02%.

    FilenameBase (646e6a9)Merge (99a876c)Diff
    exception.cc84.21%23.68%-60.53%
    exception_apple.mm65.52%96.55%+31.03%
    grpc_nanopb.cc94.87%100.00%+5.13%
    leveldb_key.cc98.14%98.82%+0.69%
    ordered_code.cc94.39%93.90%-0.49%
    task.cc93.91%94.78%+0.87%
    watch_stream.cc90.70%95.35%+4.65%
    write_stream.cc94.37%91.55%-2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qWlGSlwYQB.html
@milaGGL milaGGL requested review from dconeybe and wu-hui October 24, 2022 22:23
dconeybe
dconeybe approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for syncing up the spec tests!
@milaGGL milaGGL removed the request for review from wu-hui October 25, 2022 17:06
@milaGGL milaGGL merged commit e4ef6b0 into master Oct 25, 2022
@milaGGL milaGGL deleted the mila/sync-spec-tests-in-web-and-ios-sdks branch October 25, 2022 17:06
@firebase firebase locked and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore

3 participants

@milaGGL @google-oss-bot @dconeybe