Skip to content

Conversation

@leon
Copy link
Contributor

@leon leon commented Jan 8, 2021

Description

The 4GB memory option was not added everywhere.

Fixes #834

Tests are added verifying that the 4GB option works

Leon Radley added 2 commits January 8, 2021 08:43
The 4GB memory option was not added everywhere. Fixes firebase#834
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the oversight!

@joehan
Copy link
Contributor

joehan commented Jan 12, 2021

firebase/firebase-tools#3026 filed this PR in firebase-tools to support this option in the functions emulator as well.

@joehan joehan merged commit 2f72c33 into firebase:master Jan 13, 2021
@leon leon deleted the fix/allow-4gb-memory branch January 14, 2021 12:35
@leon
Copy link
Contributor Author

leon commented Jan 14, 2021

@joehan When do you think there will be a new version released?

joehan added a commit that referenced this pull request Jan 15, 2021
* add changelog for memory options * formats * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: huangjeff5 <64040981+huangjeff5@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants