Skip to content

Add support for service account in functions.runWith #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 7, 2020
Merged

Add support for service account in functions.runWith #770

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cacf19c
Add support for service account in `functions.runWith`
egor-miasnikov Aug 28, 2020
7e0284b
Add email validation and email generation by project id
egor-miasnikov Sep 3, 2020
525b929
Merge branch 'master' into add-support-for-service-account-in-runwith
egor-miasnikov Nov 25, 2020
eb3ef4f
Merge branch 'master' into add-support-for-service-account-in-runwith
joehan Nov 30, 2020
31631e5
Merge branch 'master' into add-support-for-service-account-in-runwith
joehan Dec 2, 2020
dd660a7
Changing to serviceAccount, and adding default as an option
joehan Dec 2, 2020
f1dea44
adds a test case for default
joehan Dec 2, 2020
4c00864
refactoring to checxk for @ at the end of service account, and throw …
joehan Dec 4, 2020
30fd209
gets rid of repeated @ for generated service account emails
joehan Dec 4, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into add-support-for-service-account-in-runwith
  • Loading branch information
@joehan
joehan authored Nov 30, 2020
commit eb3ef4f9b7e982d9811091eec68a471f08b9484e
5 changes: 5 additions & 0 deletions src/function-configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,11 @@ export interface RuntimeOptions {
* Specific service account
*/
serviceAccountEmail?: string;

/**
* Ingress settings
*/
ingressSettings?: typeof INGRESS_SETTINGS_OPTIONS[number];
}

export interface DeploymentOptions extends RuntimeOptions {
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.