Update to firebase-admin v5.0.0 #66
Conversation
spec/providers/auth.spec.ts Outdated
| photoURL: 'bar.baz/foo.jpg', | ||
| disabled: false, | ||
| metadata: { | ||
| creationTime: '2016-12-15T19:37:37.059Z', |
There was a problem hiding this comment.
Can you add a small comment to call out the difference between the old and new wire formats here?
| Made some changes according to our deprecation discussion, @rjhuijsman can you take another look? I also removed the test for "should tolerate missing fields in the payload" since the test events for the other tests is already missing fields. |
rjhuijsman left a comment
rjhuijsman left a comment There was a problem hiding this comment.
Thanks! Just two small comments, otherwise LGTM!
| // handle it gracefully. | ||
| it('should tolerate missing fields in the payload', () => { | ||
| const cloudFunction = auth.user().onCreate((ev: Event<firebase.auth.UserRecord>) => ev.data); | ||
| it('should still retain createdAt and lastSignedIn', () => { |
There was a problem hiding this comment.
A comment on what "createdAt" and "lastSignedIn" are and why they should be retained would be useful.
| | ||
| return expect(cloudFunction(event)).to.eventually.deep.equal(event.data); | ||
| return Promise.all([ | ||
| cloudFunctionCreate(newEvent).then(data => { |
There was a problem hiding this comment.
We should also expect that the fields with the old name are still present in this case with the new wire format.
2 participants
Description
Update dependency to firebase-admin v5.0.0, also added shim to transform auth event payload into the new format UserRecord format from firebase-admin.
Code sample