Removing async to be consistent among examples. #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Does anyone know how I can make comments for lines / sections that were unchanged by Eric in this PR? For example, in the Cloud Firestore section and the Analytics section there are typos, but the GitHub interface won't let me make comments there. Or do I just need to do a separate PR to get those other sections updated? |
laurenzlong approved these changes Apr 9, 2020
| @rachelsaunders You have to click the "Expand" button on the file (https://screenshot.googleplex.com/nSZbXmHupPN) then you can comment on any line. |
| @laurenzlong Clicking that expand icon just lets you view those other parts of the file, but it doesn't let you comment on those lines :-( There's like a limit to the lines above and below the changed lines where you can't make comments. |
laurenzlong added a commit that referenced this pull request May 1, 2020
* Adding top-level comment and TOC for functions.handler. (#633) * Adding top-level comment and TOC for functions.handler. * Adding edits from feedback. * Refer specifically to Firebase CLI. * Adding top-level comment and TOC for functions.handler. (#633) * Adding top-level comment and TOC for functions.handler. * Adding edits from feedback. * Refer specifically to Firebase CLI. * Pin "typedoc" version to 0.14.2 (#655) * Add docstrings for handler.firestore, handler.database, and handler.https (#652) * Document a few providers * Remove extra sentence in http function docstring * Crashlytics handler details and example formatting (#656) * Adding comments for Crashlytics handler. * Removing parens for parameters per feedback. * Eg moar handlers (#657) * Adding RC and Analytics handlers. * Adding Storage object handler. * Adding Pub/Sub and Test Lab handlers. * Adding auth handler. * Fixing typo. * Removing async to be consistent among examples. (#658) * handler functions: copy-edits in comments only (#675) * Removing async syntax from Storage handlers. (#678) Co-authored-by: egilmorez <egilmore@google.com> Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixing some inconsistency in the syntax in the examples.
Also opening to broader extensions team review in general.
Thanks!