Skip to content

Conversation

@taeold
Copy link
Contributor

@taeold taeold commented Oct 28, 2025

This change would break code like this:

const functions = require("firebase-functions") functions.config() // Error: undefined is not callable

User must use v1 namespace which throws a more explicit error:

const functions = require("firebase-functions/v1") functions.config() // Error: functions.config() has been removed in firebase-functions v7.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the firebase-functions API by removing the functions.config() method from the v2 namespace. The change encourages developers to use the v1 namespace for configuration access, ensuring a more consistent and explicit API design. It also improves the developer experience by providing a more direct error message when the deprecated v2 usage is attempted.

Highlights

  • API Removal: The functions.config() API has been explicitly removed from the firebase-functions/v2 namespace.
  • Improved Error Clarity: Calling functions.config() from the v2 namespace will now result in a clearer undefined is not callable error, guiding users to the correct v1 namespace for configuration access.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the deprecated functions.config() API from the v2 namespace. The change is a simple deletion that aligns with the pull request's goal of cleaning up the v2 API and addressing a TODO for a future major release. This is a breaking change, but it is well-documented in the description. The code modification is correct and I have no further feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant