fix: prioritize boolean cors value over debug flags #1189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
taeold requested changes Aug 25, 2022
Contributor Author
| @taeold updated as per suggestion and rebased |
taeold approved these changes Aug 25, 2022
Contributor
taeold left a comment
taeold left a comment There was a problem hiding this comment.
LGTM - please fix formatting!
Thank you for an awesome contribution!
Contributor Author
| @taeold anything else I can do? |
Contributor Author
| @taeold got it now, had to run |
As discussed in firebase/firebase-tools#4862 it's not possible to disable cors in v2 functions, because the emulator enables the debug feature for cors overriding `opts.cors`. If we could prioritize the boolean flag over the debug feature, we could have both: The ability to disable cors and also prioritize the debug flag over user provided configuration.
Co-authored-by: Daniel Lee <taeold@gmail.com>
Contributor
| @stfsy I fixed your merge conflicts but it looks like you need to run |
Contributor Author
| @colerogers thank you very much 🙂 I ran |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
As discussed in firebase/firebase-tools#4862 it's not possible to disable cors in v2 functions when running in the emulator, because the emulator enables the debug feature for cors overriding
opts.cors.If we could prioritize the boolean flag over the debug feature, we could have both: The ability to disable cors and also prioritize the debug flag over user provided configuration.
Code sample