- Notifications
You must be signed in to change notification settings - Fork 218
Adds RTDB triggers for v2 functions #1127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
fredzqm reviewed May 20, 2022
inlined requested changes Jun 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some overall comments:
- We're missing
src/v2/database.jswhich is used to quiet the import linter (since the maintainer of the repo says we should pay them if we want a fix. - We've got an outstanding PR to fix some behavior around null handling in the RTDB. Did we incorporate any of that here? Can we incorporate it without doing a major version bump? We should figure out how to not throw away the author's work
- In general I think
_.isPlainObjectis more strongly verifying things than we need. The only thing we need to check is whether something hastypeof val === 'object'and that the type is notnull. - We can ship the current path pattern work for now if we need to, but I strongly suspect we'll want to create a PathPattern utilty class like we have in One Platform code. Maybe PathPattern.compile(string) which can throw if there's a malformed path. Then something like hasParams() and matchParams(atual: string): Record<string, string>.
egilmorez reviewed Jun 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple nits for you Cole, thanks!
I'll take another look when only living code remains.
inlined approved these changes Jun 8, 2022
| @rhodgkins Yep that's the one. This will apply both to v1 & v2 functions. |
TheIronDev added a commit to firebase/firebase-functions-test that referenced this pull request Aug 2, 2022
* Add and handle MockCloudEvents for RTDB-V2 This commit is a follow-up to firebase-function's addition of rtdb-v2, firebase/firebase-functions#1127. Wrap can now handle: * `database.onValueCreated` * `database.onValueDeleted` * `database.onValueUpdated` * `database.onValueWritten`
henryrivera0304 added a commit to henryrivera0304/firebase-functions-test that referenced this pull request Jul 2, 2025
* Add and handle MockCloudEvents for RTDB-V2 This commit is a follow-up to firebase-function's addition of rtdb-v2, firebase/firebase-functions#1127. Wrap can now handle: * `database.onValueCreated` * `database.onValueDeleted` * `database.onValueUpdated` * `database.onValueWritten`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds RTDB triggers for v2 functions.