Firebase Functions ships with a binary #1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…se-functions into dl-endpoint-prop
… into dl-endpoint-prop
taeold changed the base branch from dl-container-contract to dl-endpoint-prop 
inlined reviewed Nov 12, 2021
inlined reviewed Dec 9, 2021
Follows up #999 to annotate each funuctions with `__endpoint` property. Highlight of changes: * Extend unit test coverage for all v1 providers * Add `__endpoint` annotation to v1 task queue functions * Add `__requiredAPIs` annotation to task queue and scheduler functions * Explicitly set `__endpoint` to undefined in the handler namespace * No SDK-level label setting in the __endpoint annotation.
taeold changed the base branch from dl-endpoint-prop to dl-container-contract 
colerogers reviewed Jan 18, 2022
inlined approved these changes Jan 21, 2022
| const stack = await loadStack(functionsDir); | ||
| res.setHeader('content-type', 'text/yaml'); | ||
| res.send(JSON.stringify(backend)); | ||
| res.send(JSON.stringify(stack)); |
There was a problem hiding this comment.
I mean.... technically JSON is YAML?
src/cloud-functions.ts Outdated
| }, | ||
| { | ||
| api: 'cloudscheduler.googleapis.com', | ||
| reason: 'Needed for v1 scheduled functions.', |
There was a problem hiding this comment.
here's a case where I could argue for using "v1" because v2 will not use Pub/Sub.
Alternatively you can just remove this required API because it's part of the APIs that get enabled with Cloud Functions.
There was a problem hiding this comment.
I don't think Cloud Scheduler gets enabled as part of GCF, but I'm not sure what enables it since I do see it enabled when creating a new GCP project 🤔 . I'm going to add 'v1' to err on side of being safe, but can remove later when I dig in and figure out if we can rely on the cloud scheduler API being enabled on users project by some means.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We introduce a bin associated with the firebase-functions SDK! The binary exposes a simple server on localhost that describes the Firebase Functions defined in the current directory: