- Notifications
You must be signed in to change notification settings - Fork 217
Closed
Labels
Needs: Author FeedbackIssues awaiting author feedbackIssues awaiting author feedbackclosed-by-botno-recent-activity
Description
Related issues
n/a
[REQUIRED] Version info
node: v20.16.0
firebase-functions: ^5.1.0
firebase-tools: ^13.15.3
firebase-admin: "^12.3.1"
[REQUIRED] Test case
Run firebase deploy --only functions --force
[REQUIRED] Steps to reproduce
Upgrade Firebase Functions to latest version: 5.1.0
[REQUIRED] Expected behavior
Functions deploy successfully
[REQUIRED] Actual behavior
Functions fail to deploy
Were you able to successfully deploy your functions?
Initial output was:
$ firebase deploy --only functions --force === Deploying to 'my-project'... i deploying functions i functions: preparing codebase default for deployment i functions: ensuring required API cloudfunctions.googleapis.com is enabled... i functions: ensuring required API cloudbuild.googleapis.com is enabled... i artifactregistry: ensuring required API artifactregistry.googleapis.com is enabled... ✔ artifactregistry: required API artifactregistry.googleapis.com is enabled ✔ functions: required API cloudbuild.googleapis.com is enabled ✔ functions: required API cloudfunctions.googleapis.com is enabled i functions: Loading and analyzing source code for codebase default to determine what to deploy Serving at port 8[79](https://github.com/my-repo/actions/runs/10479672777/job/29025902274#step:7:80)0 ✔ extensions: required API firebaseextensions.googleapis.com is enabled i extensions: ensuring required API firebaseextensions.googleapis.com is enabled... ✔ extensions: required API firebaseextensions.googleapis.com is enabled Error: An unexpected error has occurred. Error: Process completed with exit code 2.
Running deploy with debugging shows this detail:
[2024-08-21T14:58:54.306Z] TypeError: Cannot convert undefined or null to object at Function.entries (<anonymous>) at Object.want (/home/runner/work/my-repo/node_modules/firebase-tools/lib/deploy/extensions/planner.js:120:28) at prepareDynamicExtensions (/home/runner/work/my-repo/node_modules/firebase-tools/lib/deploy/extensions/prepare.js:122:48) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async prepare (/home/runner/work/my-repo/node_modules/firebase-tools/lib/deploy/functions/prepare.js:62:9) at async chain (/home/runner/work/my-repo/node_modules/firebase-tools/lib/deploy/index.js:40:9) at async deploy (/home/runner/work/my-repo/node_modules/firebase-tools/lib/deploy/index.js:97:5)
Downgrading identical code to v5.0.1 works. So it's definitely an issue with v5.1.0, which included this: #1590 related to extensions.
urakozz, aam-antonio, rendomnet, jeffgaynor, vramana and 2 more
Metadata
Metadata
Assignees
Labels
Needs: Author FeedbackIssues awaiting author feedbackIssues awaiting author feedbackclosed-by-botno-recent-activity