Skip to content

Conversation

EnduringBeta
Copy link
Contributor

@EnduringBeta EnduringBeta commented Oct 2, 2024

Description

Attempting to resolve #241

My process was:

  1. Search for 'firebase-functions', and add /v1 to all 16 instances
  2. Search for 'firebase-functions/v2, and remove /v2 from all 64 instances (note the lack of closing single quote to catch subdirectories)
  3. I noticed 3 instances of firebase-functions/params, but there appears to be no /v1/ version for that. I left it alone.

Tests are passing. I may have gotten things wrong, but hopefully this grunt work gets maintainers closer to an update.

@EnduringBeta EnduringBeta marked this pull request as ready for review October 2, 2024 19:10
@EnduringBeta EnduringBeta changed the title 241-update-to-firebase-functions-6 Update to firebase-functions 6 Oct 2, 2024
@Berlioz Berlioz self-requested a review December 16, 2024 19:19
@Berlioz Berlioz self-assigned this Dec 16, 2024
@Berlioz Berlioz merged commit b78cbc4 into firebase:master Dec 17, 2024
1 check passed
@Berlioz Berlioz mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants