chore: Fix release script #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
thatfiredev reviewed Oct 24, 2023
.github/workflows/release.yaml Outdated
| if: > | ||
| github.event.pull_request.merged && | ||
| github.ref == 'main' && | ||
| github.ref == 'refs/heads/master' && |
Member
There was a problem hiding this comment.
Should this be refs/heads/main instead? (looks like this repo uses main instead of master)
joehan approved these changes Oct 24, 2023
Collaborator
joehan left a comment
joehan left a comment There was a problem hiding this comment.
LGTM assuming the version drop is intentional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Release script is broken. Following firebase/firebase-admin-node#2313, we also update the github.ref to correctly match against PR merged against the main branch.