boringSSL clone specific commit #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
DellaBitta added the tests-requested: full 
github-actions bot added tests: in-progress 
❌ Integration test FAILEDRequested by @DellaBitta on commit 2b212a3
|
firebase-workflow-trigger bot removed the tests: in-progress 
vimanyu reviewed Jun 22, 2021
vimanyu reviewed Jun 22, 2021
DellaBitta added tests-requested: quick github-actions bot added tests: in-progress firebase-workflow-trigger bot removed the tests: in-progress github-actions bot added tests: in-progress firebase-workflow-trigger bot removed the tests: in-progress DellaBitta added a commit that referenced this pull request Jul 8, 2021
…hon script in #344 (#507) Previously we downloaded a tarball release of uWebSockets and then patched the code to fix a crash issue. The patch was executed by a custom python script which somewhat blindly overwrote at set of line numbers in the file. See PR #344 Git apply patch wasn't used because it requires a initialized git repo to work. Cloning the the uWebsockets repo with history and then checking out to an older commit would explode the disk usage, causing parition exhaustion issues on Windows, so we were forced to use the non-git-initialized tarball. Thankfully I found a way to fetch a repo at a specific commit, removing the overhead of cloning all of the history. This change updates the cmake download step for uWebSockets to fetch the commit instead of downloading a tarball. With a git initialized repo we can our change with a far safer git apply patch instead of our custom python script, akin to what was done for boringSSL in PR #485
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Found a way to clone the boringSSL sources to a specific commit, instead of cloning the repo first and then checking out a commit.
This frees up enough disk space that we no longer need to copy the resulting artifacts over to the C drive on Windows hosts in order to make enough room for the google cloud sdk installation. Therefore I've removed that step from the CI saving up to 20 minutes per windows integration test build.