Skip to content

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Update the XCode version the GitHub runners use to 16.3, to see what happens.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.
Copy link

Summary of Changes

Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to upgrade the Xcode version used for building and testing the project within its GitHub Actions CI/CD pipelines to 16.3. This ensures that the project remains compatible with the latest development tools and that all builds and tests are performed against the most current Xcode environment, aligning the project with recent Apple ecosystem updates.

Highlights

  • Xcode Version Update: The pull request updates the specified Xcode version used across the project's CI/CD configurations and documentation from 16.2 to 16.3.
  • CI/CD Configuration: The scripts/gha/print_matrix_configuration.py file has been modified to reflect Xcode 16.3 for desktop, Android, and iOS build matrices.
  • Documentation Update: The release_build_files/readme.md file now states that the provided libraries have been tested with Xcode 16.3.
Ignored Files
  • Ignored by pattern: .github/workflows/** (3)
    • .github/workflows/android.yml
    • .github/workflows/cpp-packaging.yml
    • .github/workflows/integration_tests.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Xcode version from 16.2 to 16.3 in the CI configuration and the README. The changes are consistent across the files. My review includes suggestions to remove some redundant configuration in scripts/gha/print_matrix_configuration.py to improve maintainability.

Comment on lines 83 to 86
EXPANDED_KEY: {
"os": ["ubuntu-22.04", "macos-14", "windows-latest"],
"xcode_version": ["16.2"],
"xcode_version": ["16.3"],
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The xcode_version is already defined in the base matrix for the desktop workflow on line 80. This entry in the EXPANDED_KEY block is redundant and can be removed to improve maintainability. The script's logic will fall back to the base matrix value if it's not found here.

 EXPANDED_KEY: { "os": ["ubuntu-22.04", "macos-14", "windows-latest"] }
Comment on lines 146 to 148
EXPANDED_KEY: {
"xcode_version": ["16.2"]
"xcode_version": ["16.3"]
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The xcode_version is already defined in the base matrix for the ios workflow on line 144. This makes the EXPANDED_KEY block redundant, as it only contains this duplicated version. The entire block can be removed to simplify the configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant