- Notifications
You must be signed in to change notification settings - Fork 126
Update XCode version to 16.3 #1792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to upgrade the Xcode version used for building and testing the project within its GitHub Actions CI/CD pipelines to 16.3. This ensures that the project remains compatible with the latest development tools and that all builds and tests are performed against the most current Xcode environment, aligning the project with recent Apple ecosystem updates. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Xcode version from 16.2 to 16.3 in the CI configuration and the README. The changes are consistent across the files. My review includes suggestions to remove some redundant configuration in scripts/gha/print_matrix_configuration.py
to improve maintainability.
EXPANDED_KEY: { | ||
"os": ["ubuntu-22.04", "macos-14", "windows-latest"], | ||
"xcode_version": ["16.2"], | ||
"xcode_version": ["16.3"], | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The xcode_version
is already defined in the base matrix for the desktop
workflow on line 80. This entry in the EXPANDED_KEY
block is redundant and can be removed to improve maintainability. The script's logic will fall back to the base matrix value if it's not found here.
EXPANDED_KEY: { "os": ["ubuntu-22.04", "macos-14", "windows-latest"] }
EXPANDED_KEY: { | ||
"xcode_version": ["16.2"] | ||
"xcode_version": ["16.3"] | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Update the XCode version the GitHub runners use to 16.3, to see what happens.
Testing
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.