Skip to content

Add retry to C++ packaging step. #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 23, 2024
Merged

Add retry to C++ packaging step. #1527

merged 9 commits into from
Jan 23, 2024

Conversation

@jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jan 23, 2024 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Add a retry for scheduled cpp-packaging similar to integration-tests, for transient errors only.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Temporarily allowed for non-scheduled runs and tested here: https://github.com/firebase/firebase-cpp-sdk/actions/runs/7632039407/attempts/1

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jan 23, 2024
@jonsimantov jonsimantov requested a review from a-maurice January 23, 2024 18:44
@jonsimantov jonsimantov enabled auto-merge (squash) January 23, 2024 21:38
@jonsimantov jonsimantov merged commit 27af7d6 into main Jan 23, 2024
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jan 23, 2024
@github-actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 27af7d6
Last updated: Tue Jan 23 16:15 PST 2024
View integration test log & download artifacts

Failures Configs
app_check [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseAppCheckTest.TestFunctionsSuccess
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
[TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  FirestoreIntegrationTest.TimestampsAreTruncatedToMicroseconds
gma [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseGmaTest.TestAdView
remote_config [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jan 24, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 24, 2024
@firebase firebase locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

2 participants

@jonsimantov @a-maurice