Skip to content

Reference untrusted git branch names via environment variables. #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 13, 2024
Merged

Reference untrusted git branch names via environment variables. #1516

merged 7 commits into from
Jan 13, 2024

Conversation

@jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jan 12, 2024 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Per recommendation here: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-an-intermediate-environment-variable

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 12, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jan 12, 2024
@github-actions
Copy link

github-actions bot commented Jan 12, 2024 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 93a51a7
Last updated: Fri Jan 12 19:09 PST 2024
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  AggregateCountTest.TestQueriesCanUseNotInFiltersWithDocIds
[TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(6 failed tests)  ServerTimestampTest.TestServerTimestampsCanReturnEstimatedValue
  ServerTimestampTest.TestServerTimestampsCanReturnPreviousValue
  ServerTimestampTest.TestServerTimestampsWorkViaSet
  ServerTimestampTest.TestServerTimestampsWorkViaTransactionSet
  ServerTimestampTest.TestServerTimestampsWorkViaTransactionUpdate
  ServerTimestampTest.TestServerTimestampsWorkViaUpdate
gma [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(2 failed tests)  FirebaseGmaTest.TestInterstitialAdLoad
  FirebaseGmaTest.TestInterstitialAdLoadEmptyRequest
storage [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 12, 2024
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jan 12, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 12, 2024
@jonsimantov jonsimantov added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jan 12, 2024
@jonsimantov jonsimantov added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jan 12, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels Jan 12, 2024
@jonsimantov jonsimantov changed the title Add quotes around github ref names, and switch to sha for most cases. Add quotes around github ref names to prevent special characters in branch names from breaking things Jan 12, 2024
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 12, 2024
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Jan 12, 2024
@jonsimantov jonsimantov changed the title Add quotes around github ref names to prevent special characters in branch names from breaking things Reference untrusted git branch names via environment variables. Jan 12, 2024
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Jan 12, 2024
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Jan 12, 2024
@jonsimantov jonsimantov enabled auto-merge (squash) January 12, 2024 22:52
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jan 13, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 13, 2024
@github-actions github-actions bot added tests: succeeded This PR's integration tests succeeded. and removed tests: failed This PR's integration tests failed. labels Jan 13, 2024
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Jan 13, 2024
@jonsimantov jonsimantov merged commit 111c1a2 into main Jan 13, 2024
@firebase firebase locked and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

2 participants

@jonsimantov @cynthiajoan