Skip to content

OR Query Implementation #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Sep 22, 2023
Merged

OR Query Implementation #1453

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
cbe1932
OR Query Implementation
tom-andersen May 29, 2023
e2623f6
Pretty
tom-andersen May 29, 2023
aa2a045
Add includes
tom-andersen Jun 13, 2023
516ff39
Fix from PR feedback
tom-andersen Jun 13, 2023
f858b7b
Fix variadic parameters
tom-andersen Jun 15, 2023
9a0f88a
Add and fix tests
tom-andersen Jun 16, 2023
fd4e5dd
Add/fix method descriptions.
tom-andersen Jun 19, 2023
602a463
Add/fix constructor and class descriptions.
tom-andersen Jun 19, 2023
959f53b
Add method description to disjunction/conjunction.
tom-andersen Jun 19, 2023
0f3e62f
Add tests. Revealed bugs to be fixed.
tom-andersen Jun 20, 2023
95b2a8c
Fix type
tom-andersen Jun 20, 2023
787ec3c
Add test
tom-andersen Jun 20, 2023
56f15c2
Android implementation
tom-andersen Jun 22, 2023
1a6d116
Pretty
tom-andersen Jun 22, 2023
a26cf80
Pretty
tom-andersen Jun 22, 2023
62fcf27
Pretty
tom-andersen Jun 22, 2023
bc3cba0
Remove const
tom-andersen Jun 22, 2023
fe5b6e8
Pretty
tom-andersen Jun 22, 2023
a232d50
Fixes from code review
tom-andersen Jun 28, 2023
1c71573
Merge branch 'main' into tomandersen/or_query
tom-andersen Jun 28, 2023
d6961a7
Release notes
tom-andersen Jun 29, 2023
678262c
Merge branch 'main' into tomandersen/or_query
tom-andersen Jun 29, 2023
6f3fc73
Release notes
tom-andersen Jun 29, 2023
a43892b
Merge remote-tracking branch 'origin/main' into tomandersen/or_query
tom-andersen Jul 17, 2023
bfa8e5e
Merge remote-tracking branch 'origin/main' into tomandersen/or_query
tom-andersen Sep 18, 2023
156ea40
Fix Android OR Query
tom-andersen Sep 21, 2023
ab93d43
Release notes.
tom-andersen Sep 21, 2023
a81a803
Merge remote-tracking branch 'origin/main' into tomandersen/or_query
tom-andersen Sep 21, 2023
bda2909
Fix release notes.
tom-andersen Sep 21, 2023
d7555da
Format
tom-andersen Sep 21, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove const
  • Loading branch information
@tom-andersen
tom-andersen committed Jun 22, 2023
commit bc3cba0ed7330bd59839dba8acff381ff02267e6
6 changes: 3 additions & 3 deletions firestore/src/android/filter_android.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,11 +149,11 @@ Filter FilterInternal::NotIn(const FieldPath& field,
return Where(field, kNotIn, values);
}

Filter FilterInternal::And(const std::vector<const Filter>& filters) {
Filter FilterInternal::And(const std::vector<Filter>& filters) {
return Where(kAnd, filters);
}

Filter FilterInternal::Or(const std::vector<const Filter>& filters) {
Filter FilterInternal::Or(const std::vector<Filter>& filters) {
return Where(kOr, filters);
}

Expand Down Expand Up @@ -185,7 +185,7 @@ Filter FilterInternal::Where(const FieldPath& field,
}

Filter FilterInternal::Where(const StaticMethod<Object>& method,
const std::vector<const Filter>& filters) {
const std::vector<Filter>& filters) {
Env env = GetEnv();
size_t size = filters.size();
Local<Array<Object>> java_filters = env.NewArray(size, Object::GetClass());
Expand Down
6 changes: 3 additions & 3 deletions firestore/src/android/filter_android.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ class FilterInternal final {
const std::vector<FieldValue>& values);
static Filter NotIn(const FieldPath& field,
const std::vector<FieldValue>& values);
static Filter Or(const std::vector<const Filter>& filters);
static Filter And(const std::vector<const Filter>& filters);
static Filter Or(const std::vector<Filter>& filters);
static Filter And(const std::vector<Filter>& filters);

const jni::Global<jni::Object>& ToJava() const { return object_; }

Expand All @@ -74,7 +74,7 @@ class FilterInternal final {
const jni::StaticMethod<jni::Object>& method,
const std::vector<FieldValue>& values);
static Filter Where(const jni::StaticMethod<jni::Object>& method,
const std::vector<const Filter>& filters);
const std::vector<Filter>& filters);
};

bool operator==(const FilterInternal& lhs, const FilterInternal& rhs);
Expand Down
4 changes: 2 additions & 2 deletions firestore/src/common/filter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,11 @@ Filter Filter::NotIn(const FieldPath& field,
return FilterInternal::NotIn(field, values);
}

Filter Filter::And(const std::vector<const Filter>& filters) {
Filter Filter::And(const std::vector<Filter>& filters) {
return FilterInternal::And(filters);
}

Filter Filter::Or(const std::vector<const Filter>& filters) {
Filter Filter::Or(const std::vector<Filter>& filters) {
return FilterInternal::Or(filters);
}

Expand Down
8 changes: 4 additions & 4 deletions firestore/src/include/firebase/firestore/filter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ class Filter {
*/
template <typename... Filters>
static Filter And(const Filters&... filters) {
return And(std::vector<const Filter>({filters...}));
return And(std::vector<Filter>({filters...}));
}

/**
Expand All @@ -307,7 +307,7 @@ class Filter {
*/
template <typename... Filters>
static Filter Or(const Filters&... filters) {
return Or(std::vector<const Filter>({filters...}));
return Or(std::vector<Filter>({filters...}));
}

/**
Expand Down Expand Up @@ -355,8 +355,8 @@ class Filter {
friend bool operator==(const Filter& lhs, const Filter& rhs);
friend struct ConverterImpl;

static Filter And(const std::vector<const Filter>& filters);
static Filter Or(const std::vector<const Filter>& filters);
static Filter And(const std::vector<Filter>& filters);
static Filter Or(const std::vector<Filter>& filters);

bool IsEmpty() const;

Expand Down
6 changes: 3 additions & 3 deletions firestore/src/main/filter_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,11 @@ Filter FilterInternal::NotIn(const FieldPath& field,
return UnaryFilter(field, FieldFilterOperator::NotIn, values);
}

Filter FilterInternal::Or(const std::vector<const Filter>& filters) {
Filter FilterInternal::Or(const std::vector<Filter>& filters) {
return CompositeFilter(CompositeOperator::Or, filters);
}

Filter FilterInternal::And(const std::vector<const Filter>& filters) {
Filter FilterInternal::And(const std::vector<Filter>& filters) {
return CompositeFilter(CompositeOperator::And, filters);
}

Expand All @@ -99,7 +99,7 @@ Filter FilterInternal::UnaryFilter(const FieldPath& field_path,

Filter FilterInternal::CompositeFilter(
core::CompositeFilter::Operator op,
const std::vector<const Filter>& filters) {
const std::vector<Filter>& filters) {
std::vector<FilterInternal*> nonEmptyFilters;
for (const Filter& filter : filters) {
FilterInternal* filterInternal = GetInternal(&filter);
Expand Down
6 changes: 3 additions & 3 deletions firestore/src/main/filter_main.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ class FilterInternal {
const std::vector<FieldValue>& values);
static Filter NotIn(const FieldPath& field,
const std::vector<FieldValue>& values);
static Filter Or(const std::vector<const Filter>& filters);
static Filter And(const std::vector<const Filter>& filters);
static Filter Or(const std::vector<Filter>& filters);
static Filter And(const std::vector<Filter>& filters);

virtual core::Filter ToCoreFilter(
const api::Query& query,
Expand Down Expand Up @@ -90,7 +90,7 @@ class FilterInternal {
const std::vector<FieldValue>& values);

static Filter CompositeFilter(CompositeOperator op,
const std::vector<const Filter>& filters);
const std::vector<Filter>& filters);
};

bool operator==(const FilterInternal& lhs, const FilterInternal& rhs);
Expand Down