Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
3b736ad
initial Auth deprecations
DellaBitta Mar 10, 2023
86cc5bd
all three platforms build
DellaBitta Mar 10, 2023
e7ad4aa
FirebaseAuth.java and auth_test.cc fixes
DellaBitta Mar 12, 2023
16ec678
format
DellaBitta Mar 12, 2023
323d41d
bundle identifer
DellaBitta Mar 13, 2023
b247244
removed explicit from CurrentUserBlockListener constructor
DellaBitta Mar 13, 2023
d5c4dea
added tests, desktop impl, desktop passes
DellaBitta Mar 30, 2023
fec108a
iOS builds and tests pass
DellaBitta Mar 30, 2023
894fbf2
android builds and passes tests
DellaBitta Mar 31, 2023
da66a6a
[Auth] PhoneAuthCredential support (#1253)
DellaBitta Apr 6, 2023
e14ad7d
[Auth] PhoneAuthOptions struct for VerifyPhoneNumber (#1257)
DellaBitta Apr 6, 2023
0f0eefd
Merge branch 'main' into feature/auth_googleio_23
DellaBitta Apr 6, 2023
ac3a965
Add new Auth and User methods to replace the deprecated ones (#1264)
DellaBitta Apr 12, 2023
4351bcd
Auth I/O '23 - update other SDK iTests to use new API (#1268)
DellaBitta Apr 14, 2023
37d14ee
Default no-op for deprecated virtual function (#1275)
chkuang-g Apr 19, 2023
9aa7f13
Merge branch 'main' into feature/auth_googleio_23
jonsimantov Apr 21, 2023
a0d48e5
Fix Doxygen warnings.
jonsimantov Apr 21, 2023
9ae3c3e
Additional docs fixes.
jonsimantov Apr 21, 2023
59e9501
Fix lint warning.
jonsimantov Apr 21, 2023
0167482
Added readme note about deprecated methods.
jonsimantov Apr 25, 2023
41a25a0
Merge branch 'main' into feature/auth_googleio_23
jonsimantov Apr 25, 2023
218a528
Merge branch 'main' into feature/auth_googleio_23
jonsimantov Apr 27, 2023
abe2f0c
Remove "_DEPRECATED" from LinkAndRetrieveDataWithCredential (#1290)
chkuang-g Apr 28, 2023
22bcdbd
Merge branch 'main' into feature/auth_googleio_23
jonsimantov Apr 28, 2023
a09e1d4
Merge branch 'main' into feature/auth_googleio_23
jonsimantov May 1, 2023
90e3da2
Auth Google I/0 23 - Update doc examples to use new API (#1271)
DellaBitta May 1, 2023
2b32d91
Merge branch 'main' into feature/auth_googleio_23
jonsimantov May 2, 2023
2b31406
Merge branch 'main' into feature/auth_googleio_23
jonsimantov May 2, 2023
289a7b5
Merge branch 'main' into feature/auth_googleio_23
jonsimantov May 2, 2023
bad6254
Merge branch 'main' into feature/auth_googleio_23
jonsimantov May 2, 2023
1282776
Merge branch 'main' into feature/auth_googleio_23
jonsimantov May 2, 2023
1521a08
Add comparison operator for Auth::User (#1301)
chkuang-g May 3, 2023
6461cb9
Merge branch 'main' into feature/auth_googleio_23
jonsimantov May 3, 2023
c6b7e0a
Fix broken Auth unit tests
chkuang-g May 3, 2023
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions app_check/integration_test/src/integration_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -406,12 +406,12 @@ void FirebaseAppCheckTest::TerminateFunctions() {
}

void FirebaseAppCheckTest::SignIn() {
if (auth_->current_user() != nullptr) {
if (auth_->current_user().is_valid()) {
// Already signed in.
return;
}
LogDebug("Signing in.");
firebase::Future<firebase::auth::User*> sign_in_future =
firebase::Future<firebase::auth::AuthResult> sign_in_future =
auth_->SignInAnonymously();
WaitForCompletion(sign_in_future, "SignInAnonymously");
if (sign_in_future.error() != 0) {
Expand All @@ -426,15 +426,15 @@ void FirebaseAppCheckTest::SignOut() {
// Auth is not set up.
return;
}
if (auth_->current_user() == nullptr) {
if (!auth_->current_user().is_valid()) {
// Already signed out.
return;
}
if (auth_->current_user()->is_anonymous()) {
if (auth_->current_user().is_anonymous()) {
// If signed in anonymously, delete the anonymous user.
WaitForCompletion(auth_->current_user()->Delete(), "DeleteAnonymousUser");
WaitForCompletion(auth_->current_user().Delete(), "DeleteAnonymousUser");
// If there was a problem deleting the user, try to sign out at least.
if (auth_->current_user()) {
if (auth_->current_user().is_valid()) {
auth_->SignOut();
}
} else {
Expand All @@ -443,11 +443,11 @@ void FirebaseAppCheckTest::SignOut() {
auth_->SignOut();

// Wait for the sign-out to finish.
while (auth_->current_user() != nullptr) {
while (auth_->current_user().is_valid()) {
if (ProcessEvents(100)) break;
}
}
EXPECT_EQ(auth_->current_user(), nullptr);
EXPECT_FALSE(auth_->current_user().is_valid());
}

firebase::database::DatabaseReference FirebaseAppCheckTest::CreateWorkingPath(
Expand Down Expand Up @@ -559,7 +559,7 @@ TEST_F(FirebaseAppCheckTest, TestSignIn) {
InitializeAppCheckWithDebug();
InitializeApp();
InitializeAuth();
EXPECT_NE(auth_->current_user(), nullptr);
EXPECT_TRUE(auth_->current_user().is_valid());
}

TEST_F(FirebaseAppCheckTest, TestDebugProviderValidToken) {
Expand Down
1 change: 1 addition & 0 deletions auth/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ build_flatbuffers("${flatbuffer_schemas}"
# Common source files used by all platforms
set(common_SRCS
src/auth.cc
src/credential.cc
src/common.cc
src/common.h
src/data.h
Expand Down
Loading