Skip to content

remove @ref after @deprecated to bypass devsite check #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2022
Merged

remove @ref after @deprecated to bypass devsite check #1110

merged 1 commit into from
Oct 13, 2022

Conversation

@cynthiajoan
Copy link
Contributor

@cynthiajoan cynthiajoan commented Oct 13, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.
@cynthiajoan cynthiajoan requested a review from a-maurice October 13, 2022 22:54
@cynthiajoan cynthiajoan added the skip-release-notes Skip release notes check label Oct 13, 2022
@cynthiajoan cynthiajoan merged commit 3213f0e into main Oct 13, 2022
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Oct 13, 2022
@github-actions
Copy link

github-actions bot commented Oct 13, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @cynthiajoan on commit 3213f0e
Last updated: Thu Oct 13 19:37 PDT 2022
View integration test log & download artifacts

Failures Configs
storage [TEST] [ERROR] [iOS] [macos] [All 2 ios_device]
[TEST] [ERROR] [tvOS] [macos] [tvos_simulator]
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Oct 14, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 14, 2022
@firebase firebase locked and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

2 participants

@cynthiajoan @a-maurice