[vertexai] Include appcheck token unconditionally #6409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The app check backend can differentiate between apps that do not use appcheck at all, and those sending invalid data, by using a special placeholder token when errors happen. We were previously not including the token value in error cases, but we should.
Contributor
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-vertexai### {{firebase_vertexai}} version 16.0.2 {: #vertex-ai_v16-0-2} * {{fixed}} Fixed issue where Firebase App Check error tokens were unintentionally missing from the requests. GitHub [#6409](//github.com/firebase/firebase-android-sdk/issues/6409){: .external} |
Contributor
Vertex AI Mock Responses Check |
Contributor
Test Results 20 files - 1 002 20 suites - 1 002 15s ⏱️ - 36m 12s Results for commit 09c3ef9. ± Comparison against base commit d96507b. This pull request removes 5697 tests.♻️ This comment has been updated with latest results. |
daymxn approved these changes Oct 23, 2024
rachelsaunders requested changes Oct 23, 2024
firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/GenerativeModel.kt Outdated Show resolved Hide resolved
Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
rachelsaunders requested changes Oct 24, 2024
firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/GenerativeModel.kt Outdated Show resolved Hide resolved
firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/GenerativeModel.kt Outdated Show resolved Hide resolved
Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
…/GenerativeModel.kt Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
rachelsaunders approved these changes Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The app check backend can differentiate between apps that do not use appcheck at all, and those sending invalid data, by using a special placeholder token when errors happen. We were previously not including the token value in error cases, but we should.