Skip to content

Add dependency on empty version of listenablefuture. #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2018
Merged

Add dependency on empty version of listenablefuture. #58

merged 1 commit into from
Oct 4, 2018

Conversation

@vkryachko
Copy link
Member

@vkryachko vkryachko commented Oct 4, 2018

This avoids the classpath conflict when both guava and listenablefuture
libraries are present.

See https://groups.google.com/forum/#!topic/guava-announce/Km82fZG68Sw
for context.
@vkryachko
Add dependency on empty version of listenablefuture.
71f2898 
This avoids the classpath conflict when both guava and listenablefuture libraries are present. See https://groups.google.com/forum/#!topic/guava-announce/Km82fZG68Sw for context.
@vkryachko vkryachko requested review from bjornick and wilhuff October 4, 2018 19:26
@vkryachko
Copy link
Member Author

vkryachko commented Oct 4, 2018

/test smoke-tests-debug
@vkryachko vkryachko merged commit df85231 into master Oct 4, 2018
@vkryachko vkryachko deleted the vk.firestore-guava-fix branch October 4, 2018 20:12
@saurabhdtu saurabhdtu mentioned this pull request Nov 20, 2018
Closed
@firebase firebase locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size/XS

3 participants

@vkryachko @ashwinraghav @google-oss-bot