Skip to content

Catch SQLException when doing best effort forced send in Crashlytics. #4608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2023
Merged

Catch SQLException when doing best effort forced send in Crashlytics. #4608

merged 2 commits into from
Jan 31, 2023

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Jan 30, 2023

This exception gets thrown sometimes when Crashlytics attempts to do a forced send at a bad time (#4496). Since the forced send is best effort anyway, it is safe to just fail in this case and let the regular scheduled send happen on the next launch.
@mrober mrober requested a review from vkryachko January 30, 2023 20:05
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 30, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-crashlytics

    Overall coverage changed from 10.16% (96ef850) to 10.16% (f4a9b82) by -0.00%.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/GYRlNCkxkK.html
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023 •
edited
Loading

Unit Test Results

  6 files   -    152    6 suites   - 152   19s ⏱️ - 2m 28s
18 tests  - 1 094  18 ✔️  - 1 078  0 💤  - 16  0 ❌ ±0 
36 runs   - 2 188  36 ✔️  - 2 156  0 💤  - 32  0 ❌ ±0 

Results for commit 34003fd. ± Comparison against base commit 9d99981.

♻️ This comment has been updated with latest results.
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 30, 2023 •
edited
Loading

Size Report 1

Affected Products

  • firebase-crashlytics

    TypeBase (96ef850)Merge (f4a9b82)Diff
    aar351 kB351 kB+32 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/v362qYkqH6.html
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 30, 2023 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile96ef850f4a9b82DiffSignificant (?)
    p10166 ±23 ms166 ±8 ms+224 μs (+0.1%)NO
    p25172 ±25 ms171 ±8 ms-1.15 ms (-0.7%)NO
    p50179 ±30 ms178 ±9 ms-1.37 ms (-0.8%)NO
    p75187 ±34 ms188 ±17 ms+1.27 ms (+0.7%)NO
    p90196 ±40 ms199 ±20 ms+2.31 ms (+1.2%)NO

    20 test runs in comparison
    CommitTest Runs
    96ef850
    • 2023-01-30_23:04:50.254495_ciRC
    • 2023-01-30_23:04:50.256066_BzWH
    • 2023-01-30_23:04:50.256082_EZhP
    • 2023-01-30_23:04:50.256090_wWkl
    • 2023-01-30_23:04:50.256097_zKDN
    • 2023-01-30_23:04:50.256104_HsIC
    • 2023-01-30_23:04:50.256112_OoUd
    • 2023-01-30_23:04:50.256123_LBQl
    • 2023-01-30_23:04:50.256129_vAAk
    • 2023-01-30_23:04:50.256135_uLiR
    f4a9b82
    • 2023-01-31_17:10:25.268370_Yhaq
    • 2023-01-31_17:10:25.271738_GLsm
    • 2023-01-31_17:10:25.271760_CSsm
    • 2023-01-31_17:10:25.271768_mEeo
    • 2023-01-31_17:10:25.271775_yeLC
    • 2023-01-31_17:10:25.271781_fIoA
    • 2023-01-31_17:10:25.271789_XYJd
    • 2023-01-31_17:10:25.271796_qydu
    • 2023-01-31_17:10:25.271802_Bmnm
    • 2023-01-31_17:10:25.271808_xHIH
    redfin-30
    Percentile96ef850f4a9b82DiffSignificant (?)
    p10184 ±4 ms206 ±3 ms+22.3 ms (+12.1%)YES
    p25190 ±4 ms212 ±3 ms+22.0 ms (+11.6%)YES
    p50197 ±3 ms220 ±3 ms+23.1 ms (+11.8%)YES
    p75204 ±3 ms228 ±4 ms+24.0 ms (+11.8%)YES
    p90212 ±4 ms241 ±5 ms+28.1 ms (+13.2%)YES

    20 test runs in comparison
    CommitTest Runs
    96ef850
    • 2023-01-30_23:04:50.254495_ciRC
    • 2023-01-30_23:04:50.256066_BzWH
    • 2023-01-30_23:04:50.256082_EZhP
    • 2023-01-30_23:04:50.256090_wWkl
    • 2023-01-30_23:04:50.256097_zKDN
    • 2023-01-30_23:04:50.256104_HsIC
    • 2023-01-30_23:04:50.256112_OoUd
    • 2023-01-30_23:04:50.256123_LBQl
    • 2023-01-30_23:04:50.256129_vAAk
    • 2023-01-30_23:04:50.256135_uLiR
    f4a9b82
    • 2023-01-31_17:10:25.268370_Yhaq
    • 2023-01-31_17:10:25.271738_GLsm
    • 2023-01-31_17:10:25.271760_CSsm
    • 2023-01-31_17:10:25.271768_mEeo
    • 2023-01-31_17:10:25.271775_yeLC
    • 2023-01-31_17:10:25.271781_fIoA
    • 2023-01-31_17:10:25.271789_XYJd
    • 2023-01-31_17:10:25.271796_qydu
    • 2023-01-31_17:10:25.271802_Bmnm
    • 2023-01-31_17:10:25.271808_xHIH

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/epGPXPV9vC/index.html
@mrober mrober requested a review from themiswang January 31, 2023 17:10
@mrober mrober merged commit 9719e1c into master Jan 31, 2023
@mrober mrober deleted the crashlytics-sql branch January 31, 2023 19:35
@firebase firebase locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

main-merge-ack size/XS

3 participants

@mrober @google-oss-bot @themiswang