Skip to content

Add action to show a message when merging to the main branch #4301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 10, 2022
Merged

Add action to show a message when merging to the main branch #4301

merged 4 commits into from
Nov 10, 2022

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Nov 10, 2022

No description provided.

@rlazo rlazo requested a review from vkryachko November 10, 2022 05:59
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.
@rlazo
Copy link
Collaborator Author

rlazo commented Nov 10, 2022

This action will be disabled after merged until it's useful. I haven't found a way of creating a disabled action.
@rlazo rlazo requested a review from daymxn November 10, 2022 05:59
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022 •
edited
Loading

Unit Test Results

   395 files  +   344     395 suites  +344   19m 3s ⏱️ + 17m 29s
4 730 tests +3 756  4 708 ✔️ +3 734  22 💤 +22  0 ❌ ±0 
4 746 runs  +3 772  4 724 ✔️ +3 750  22 💤 +22  0 ❌ ±0 

Results for commit 57e366b. ± Comparison against base commit 4f41bde.

♻️ This comment has been updated with latest results.
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 10, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (81bf400) and merge commit (0f89861).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XyH2jadPeA.html
@vkryachko
Copy link
Member

Would it make sense to have this check require adding a tag to the pr and fail otherwise? this might make it easier to spot the action required to merge the pr
@rlazo rlazo added the WIP label Nov 10, 2022
@rlazo rlazo added main-merge-ack and removed WIP labels Nov 10, 2022
@rlazo
Copy link
Collaborator Author

rlazo commented Nov 10, 2022

Would it make sense to have this check require adding a tag to the pr and fail otherwise? this might make it easier to spot the action required to merge the pr

Done
@rlazo rlazo merged commit 0ba9bc3 into master Nov 10, 2022
@rlazo rlazo deleted the rl.mm90 branch November 10, 2022 18:25
davidmotson pushed a commit that referenced this pull request Nov 28, 2022
@rlazo
Add action to show a message when merging to the main branch (#4301)
35512c9 
* Add action to show a message when merging to the main branch * Fail if label 'merge-main-ack' is not present
@firebase firebase locked and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

main-merge-ack size/M

3 participants

@rlazo @google-oss-bot @vkryachko