Fix NonNull and Nullable annotation links #4286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vkryachko approved these changes Nov 4, 2022
rlazo approved these changes Nov 4, 2022
Size Report 1Affected ProductsNo changes between base commit (bcdf4a9) and merge commit (0152506).Test Logs |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Per b/257285420, this fixes the
@NonNulland@Nullableannotation links in the Dackka output redirecting to a 404 page.This occurred because those annotations were being provided by
androidx.annotation, wheres we don't actually have anyandroidxpackage-list files for our external links during doc generation. Looking through the source, the only public API that even usesandroidxseems to be pulling from the annotation artifact- so instead of creating a new file for it, I just added a reference toandroidx.annotationbelow our already existingandroid.annotationin our package-list files.