FAD API error handling #2835
Merged
FAD API error handling #2835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (9892f00f) is created by Prow via merging commits: 52e1cf8 21c901d. |
Contributor
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (9892f00f) is created by Prow via merging commits: 52e1cf8 21c901d. |
pranavrajgopal commented Jul 16, 2021
| | ||
| @NonNull private final Status status; | ||
| @Nullable private final AppDistributionRelease release; | ||
| |
Contributor Author
There was a problem hiding this comment.
Removing these because we should always pass a message to the FirebaseAppDistributionException since its customer facing.
rachaprince approved these changes Jul 16, 2021
| setSignInTaskCompletionError( | ||
| new FirebaseAppDistributionException(AUTHENTICATION_CANCELED)); | ||
| new FirebaseAppDistributionException( | ||
| "Tester cancelled authentication flow", AUTHENTICATION_CANCELED)); |
There was a problem hiding this comment.
Should this string also be in the constants class?
Contributor Author
There was a problem hiding this comment.
Good call! Fixed it
Contributor Author
| /retest |
pranavrajgopal force-pushed the fad-http-error-handling branch from 9c4ee05 to df97751 Compare 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adding API error handling and better error messages