Skip to content

Replace gRPC Status#equals() with Status#isOk(). #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2021
Merged

Replace gRPC Status#equals() with Status#isOk(). #2436

merged 1 commit into from
Feb 11, 2021

Conversation

@groakley
Copy link
Contributor

@groakley groakley commented Feb 11, 2021

Status#equals() uses reference equality. This will typically work for OK statuses, but will almost always fail for non-OK statuses. Status#isOk() or comparing Status#getCode() is preferred.

See cl/356819841 for additional context and motivation.
@groakley
Replace gRPC Status#equals() with Status#isOk(). Status#equals() uses…
100632f 
… reference equality. Status#isOk() or comparing Status#getCode() is preferred.
@google-cla google-cla bot added the cla: yes Override cla label Feb 11, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 11, 2021

Hi @groakley. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@schmidt-sebastian
Copy link
Contributor

schmidt-sebastian commented Feb 11, 2021

/ok-to-test
@schmidt-sebastian schmidt-sebastian self-assigned this Feb 11, 2021
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 11, 2021

Coverage Report

Affected SDKs

No changes between base commit (a493044) and head commit (a90b434c).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (a90b434c) is created by Prow via merging commits: a493044 100632f.
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 11, 2021

Binary Size Report

Affected SDKs

  • firebase-firestore

    Type Base (a493044) Head (a90b434c) Diff
    aar 1.10 MB 1.10 MB -52 B (-0.0%)
    apk (release) 3.19 MB 3.19 MB +192 B (+0.0%)

Test Logs

Notes

Head commit (a90b434c) is created by Prow via merging commits: a493044 100632f.
@schmidt-sebastian schmidt-sebastian merged commit 5947657 into firebase:master Feb 11, 2021
@firebase firebase locked and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes Override cla ok-to-test size/XS

3 participants

@groakley @google-oss-bot @schmidt-sebastian