Skip to content

Conversation

@var-const
Copy link
Contributor

No description provided.

@var-const
Copy link
Contributor Author

Tested by doing a fresh clone running the git clone command provided and verifying that ./gradlew :firebase-firestore:check succeeds (whereas it fails for the previous iteration of the command). Let me know if there are any other targets I should check.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 51.18% (24a07db) to 51.14% (0fce68eb) by -0.05%.

    Filename Base (24a07db) Head (0fce68eb) Diff
    WebsocketConnection.java 34.66% 32.39% -2.27%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (0fce68eb) is created by Prow via merging commits: 24a07db 22d5cb9.

README.md Outdated

* Install the latest Android Studio (should be 3.0.1 or later)
* Clone the repo (`git clone git@github.com:firebase/firebase-android-sdk.git`)
* Clone the repo (`git clone --recurse-submodules --remote-submodules git@github.com:firebase/firebase-android-sdk.git`)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use --remote-submodules when syncing because it pulls the submodules from "head" in their respective repos, not from the exact commit we want to.

Each project is responsible to update their remotes if deemed necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

submodules by running `git submodule update --init --recursive`.
* Import the firebase-android-sdk gradle project into Android Studio using the
**Import project(Gradle, Eclipse ADT, etc.** option.
**Import project(Gradle, Eclipse ADT, etc.)** option.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@google-oss-bot
Copy link
Contributor

@var-const: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
copyright-check d35ddf2 link /test copyright-check
smoke-tests d35ddf2 link /test smoke-tests
check-changed d35ddf2 link /test check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rlazo rlazo merged commit 0deea54 into master Sep 10, 2020
@firebase firebase locked and limited conversation to collaborators Oct 11, 2020
@kaibolay kaibolay deleted the varconst/readme-submodules branch September 14, 2022 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

4 participants