Skip to content

Fix Double Logging of FCM #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2020
Merged

Fix Double Logging of FCM #1834

merged 2 commits into from
Aug 5, 2020

Conversation

@zwu52
Copy link
Member

@zwu52 zwu52 commented Jul 30, 2020

If shouldUploadScionMetrics and w shouldUploadFirelogAnalytics both evaluate to true, logToScion is called twice for a single message.
@zwu52 zwu52 requested a review from ciarand July 30, 2020 16:11
@googlebot googlebot added the cla: yes Override cla label Jul 30, 2020
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 30, 2020 •
edited
Loading

Coverage Report

Affected SDKs

No changes between base commit (f1e32c1) and head commit (7685c1d6).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (7685c1d6) is created by Prow via merging commits: f1e32c1 0baa71b.
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 30, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase-messaging

    Type Base (f1e32c1) Head (7685c1d6) Diff
    aar 174 kB 174 kB -194 B (-0.1%)
    apk (aggressive) 493 kB 493 kB -44 B (-0.0%)
    apk (release) 2.42 MB 2.42 MB +216 B (+0.0%)

Test Logs

Notes

Head commit (7685c1d6) is created by Prow via merging commits: f1e32c1 0baa71b.
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 31, 2020

@zwu52: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed 0baa71b link /test check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
ciarand
ciarand approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@ciarand ciarand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have some tests that failed before this change
@zwu52 zwu52 merged commit f833a38 into master Aug 5, 2020
@firebase firebase locked and limited conversation to collaborators Sep 5, 2020
@kaibolay kaibolay deleted the double-logging branch September 14, 2022 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes Override cla size/L

4 participants

@zwu52 @google-oss-bot @ciarand @googlebot