Skip to content

Conversation

@ViktorSky
Copy link

This PR originates from #886.

@jonathanedey jonathanedey self-requested a review July 3, 2025 14:12
@ViktorSky
Copy link
Author

Is there any progress?

@heckad
Copy link

heckad commented Jul 25, 2025

@ViktorSky, please do rebase.

@heckad
Copy link

heckad commented Jul 26, 2025

Please add a py.typed marker and why the version is 6.9.0. Is it the correct rebase?

@ViktorSky
Copy link
Author

What do you mean by version 6.9.0?

@heckad
Copy link

heckad commented Jul 31, 2025

If I try to install package from your brunch I got 6.9.0 version. Command to reproduce

poetry add firebase-admin@git+https://github.com/ViktorSky/firebase-admin-python.git#v7
@ViktorSky
Copy link
Author

@heckad pyproject.toml is not currently implemented, so it is normal that it does not work

@jonathanedey
Copy link
Contributor

Hi @ViktorSky , this PR should be rebased back against master now that the v7 changes have been merged. Unfortunately, as mentioned before, I can't promise a timeline for reviews on this since this is not currently prioritized on our roadmap.

@ViktorSky
Copy link
Author

Hi @ViktorSky , this PR should be rebased back against master now that the v7 changes have been merged. Unfortunately, as mentioned before, I can't promise a timeline for reviews on this since this is not currently prioritized on our roadmap.

So I close this one and I have to open a new one for the master?

@jonathanedey
Copy link
Contributor

No you should be able to do this without creating a new PR by editing the target branch in the GitHub UI above and performing a rebase on your local branch.

@ViktorSky ViktorSky changed the base branch from v7 to master August 1, 2025 05:14
@ViktorSky ViktorSky closed this Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants