Skip to content

Added multiple Firestore databases support #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Added multiple Firestore databases support #728

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
71e19c4
Update firestore.py
KarenjanM Oct 4, 2023
800f885
Update _utils.py
KarenjanM Oct 4, 2023
168cd75
Update firestore.py
KarenjanM Oct 4, 2023
53f5e38
Update firestore.py
KarenjanM Oct 5, 2023
025cae4
Merge branch 'master' into master
KarenjanM Nov 2, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update firestore.py
  • Loading branch information
@KarenjanM
KarenjanM authored Oct 4, 2023
commit 168cd759026f3dce8607a32978d42a537af0006e
3 changes: 2 additions & 1 deletion firebase_admin/firestore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,10 @@ def from_app(cls, app):
"""Creates a new _FirestoreClient for the specified app."""
credentials = app.credential.get_credential()
project = app.project_id
database_id = app.options.get('database_id')
if not project:
raise ValueError(
'Project ID is required to access Firestore. Either set the projectId option, '
'or use service account credentials. Alternatively, set the GOOGLE_CLOUD_PROJECT '
'environment variable.')
return _FirestoreClient(credentials, project)
return _FirestoreClient(credentials, project, database_id)