Skip to content

fix: Correctly catch DefaultCredentialsError when looking up project_id #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 21, 2023
Merged

fix: Correctly catch DefaultCredentialsError when looking up project_id #720

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb7501f
Added additional exception catching with unit tests
jonathanedey Sep 19, 2023
a90a851
lint: fixed spacing
jonathanedey Sep 19, 2023
2c18219
fix: explicitly force exception raise in unit test
jonathanedey Sep 20, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint: fixed spacing
  • Loading branch information
@jonathanedey
jonathanedey committed Sep 19, 2023
commit a90a851a2aa12b6c4822a3da601738483487a12e
2 changes: 0 additions & 2 deletions tests/test_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,8 +320,6 @@ def test_no_project_id_from_environment(self, app_credential):
def evaluate():
app = firebase_admin.initialize_app(app_credential, name='myApp')
app._credential._g_credential = None


old_env_var = os.environ.get(env_var_name)
if old_env_var:
del os.environ[env_var_name]
Expand Down