Implementing a httpTimeout option #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bjornick requested changes Sep 18, 2017
firebase_admin/db.py Outdated
| auth_override: A dictionary representing auth variable overrides or None (optional). | ||
| Default value provides admin privileges. A None value here provides un-authenticated | ||
| guest privileges. | ||
| timeout: HTTP request timeout in seconds (optional). |
There was a problem hiding this comment.
What is the behavior if one isn't specified?
There was a problem hiding this comment.
In that case we don't set any timeout on the connection, which activates the defaults of the requests library. However, their default is essentially "never timeout". Would it be better to default to something like 60 seconds instead?
There was a problem hiding this comment.
I think we should document the default behavior. If the old behavior was "never timeout" we should probably leave it be, in case anybody depended on it.
bjornick approved these changes Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Related to #71.
A new 'httpTimeout' option is introduced which will be used to control the timeout of all outbound requests made by the
dbmodule. In the future, we can use the same in other modules too.