- Notifications
You must be signed in to change notification settings - Fork 343
User Management API with Phone Auth Support #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
23 commits Select commit Hold shift + click to select a range
577d103 Started implementing the user management API
hiranya911 94aa617 Implementing more test cases
hiranya911 e9caf60 Fixing a python 3 test failure
hiranya911 826cab4 Combined the auth tests into one module
hiranya911 f86c0b4 Implemented the rest of the user management API
hiranya911 3be855a Implemented more unit tests for user management API
hiranya911 def74cd Updated API docs
hiranya911 ba3dca7 Implemented phone number auth support
hiranya911 37724ae Stricter validation for arguments
hiranya911 15efd0a Added more tests
hiranya911 8235199 Improved test coverage
hiranya911 c91d415 Updated user management tests
hiranya911 52ab376 Test cases for valid phone numbers
hiranya911 7242fef Updated error message
hiranya911 06f3745 Updated create_user() and update_user() to accept kwargs instead of d…
hiranya911 e64bc09 Merge branch 'master' into hkj-user-mgt
hiranya911 24a4c06 Updated documentation
hiranya911 d2f76cf Refactoring code by merging some redundant lines
hiranya911 6b1e1b4 Extract user managemnt code into a separate helper module
hiranya911 ad4d7b7 Using constants in test code
hiranya911 fcec67b Fixing a typo
hiranya911 7aa00ef Merging with master (resolved conflicts in test_db.py)
hiranya911 c0f8076 Merge branch 'hkj-user-mgt' of github.com:firebase/firebase-admin-pyt…
hiranya911 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Implemented the rest of the user management API
- Loading branch information
commit f86c0b42dbecb42014a6d480a079f8ec23cbdb0c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all these get users are basically the same except for the error message. Does it make sense to have a shared implementation that takes in a parameter for the error messages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done