Skip to content

Removing universal flag from binary dist configuration #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2020
Merged

Removing universal flag from binary dist configuration #404

merged 1 commit into from
Feb 5, 2020

Conversation

@hiranya911
Copy link
Contributor

@hiranya911 hiranya911 commented Feb 5, 2020

As per https://packaging.python.org/guides/distributing-packages-using-setuptools/#universal-wheels universal flag should only be used if the code works on both Python 2 and 3 without changes.

Only use the --universal setting, if: 1. Your project runs on Python 2 and 3 with no changes (i.e. it does not require 2to3). 2. Your project does not have any C extensions.

Removing the flag to only build for Python 3 from here on.
lahirumaramba
lahirumaramba approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!
@hiranya911 hiranya911 merged commit ccefa63 into master Feb 5, 2020
@hiranya911 hiranya911 deleted the hkj-bdist-py3 branch February 5, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@hiranya911 @lahirumaramba