Support deleting custom claims by passing None #341
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In #320 we removed the ability to delete user attributes by passing
Nonetoauth.update_user(). This change inadvertently affected theauth.set_custom_user_claims()method which should support deleting claims via passingNone. This caused an integration test failure:This PR fixes the
set_custom_user_claims()method, which now supports removing claims via bothNoneandDELETE_ATTRIBUTE. I also updated theupdate_user()integration test to useDELETE_ATTRIBUTEinstead ofNone.