Caching Public Keys for ID Token and Cookie Verification #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
hiranya911 added a commit that referenced this pull request Apr 5, 2018
hiranya911 added a commit that referenced this pull request Apr 11, 2018
* Moved token generation/validation code to new helper module * Basic session cookie support (without tests) * Separated token generation and verification into two classes * Added unit tests for session management * Fixing a lint error * Added integration tests * Handling article in error messages * Fixed a lint error * Updated changelog * Added snippets for auth session management * Updated snippets * Added some comments * Merged with master; Updated CHANGELOG for #150 * Minor improvements to samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
google-authlibrary does not cache public certs. This causes all invocations ofverify_id_token()andverify_session_cookie()to make an HTTP call. This PR implements certificate caching using thecachecontrollibrary.