Skip to content

Conversation

avishalom
Copy link
Contributor

Also updated changelog

@avishalom avishalom requested a review from hiranya911 March 15, 2018 18:06
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one change suggested.

CHANGELOG.md Outdated

- [changed] Improved error handling in FCM by mapping more server-side
errors to client-side error codes.
errors to client-side error codes. See [documentation](/docs/cloud-messaging/admin/errors).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use absolute URL here.

@avishalom avishalom assigned hiranya911 and unassigned avishalom Mar 15, 2018
@avishalom avishalom merged commit 7e0d47e into master Mar 15, 2018
@avishalom avishalom deleted the vish-release-2_9_1 branch March 19, 2018 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants