Skip to content

Conversation

@hiranya911
Copy link
Contributor

No description provided.

fi

# Ensure the branch does not have local changes
if [[ `git status --porcelain` ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

earlier we used $(..) syntax, maybe replace the backticks for $(...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

sed -i "" -e "1 s/# Unreleased//" "../CHANGELOG.md"
else
sed --in-place -e "s/__version__ = '$CUR_VERSION'/__version__ = '$VERSION'/" "../firebase_admin/__init__.py"
sed --in-place -e "1 s/# Unreleased//" "../CHANGELOG.md"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"-i" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@avishalom avishalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of style nits. LGTM.

@avishalom avishalom assigned hiranya911 and unassigned avishalom Jan 24, 2018
@hiranya911 hiranya911 merged commit cec75e1 into master Jan 24, 2018
@hiranya911 hiranya911 deleted the hkj-log-update branch January 24, 2018 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants